search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

fix for cperl strict hashpairs #17

Closed rurban closed 6 years ago

rurban commented 6 years ago

fatal under use strict since v5.27.0c. See https://github.com/perl11/cperl/issues/281 and http://perl11.org/blog/strict-hashpairs.html

With map only a missing or a single pair is allowed to construct a hash, not
multiple pairs.
shlomif commented 6 years ago

Please see my comment on https://github.com/shlomif/perl-XML-LibXML/pull/16 - item 2 and comply.

rurban commented 6 years ago

The missing make docs is your problem. Haven't touched that. The MSVC breakage is even worse. All the pTHX aTHX args are missing.

shlomif commented 6 years ago

again, Please see my comment on https://github.com/shlomif/perl-XML-LibXML/pull/16 - item no. 2 there and comply. thanks!

shlomif commented 6 years ago

Closing due to lack of compliance.