search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Use Alien::Libxml2. #30

Closed genio closed 5 years ago

genio commented 5 years ago

Use the logic within Alien::Libxml2 to build against LibXML instead of trying to figure all of that out on our own.

This required quite a bit of reworking of our Makefile.PL file:

The Makefile.PL script should now be MUCH easier to read.

Removed inc/Devel/CheckLib.pm from the MANIFEST Added t/00-report-prereqs.t to provide a prerequisites report

genio commented 5 years ago

The extra addition to the CI config of installing Alien::Libxml2 first was simply because we don't have a META.json in the dist to help cpanm find Config and Build prereqs. So, the cpanm --installdeps -n . couldn't run the Makefile.PL to find out what the prereqs were in order to install them.

This won't be a problem on shipping because a shipped dist will contain the META.json file which tells of configure/build time prereqs.

genio commented 5 years ago

I'll be working with others to figure out the build failure on Windows.

shlomif commented 5 years ago

@genio : thanks! The changes look good modulo the appveyor failure.

plicease commented 5 years ago

I believe that Alien::Libxml2 version 0.06 should resolve the appveyor failure.

shlomif commented 5 years ago

On Fri, 22 Mar 2019 21:22:58 -0700 Graham✈️✈️ notifications@github.com wrote:

I believe that Alien::Libxml2 version 0.06 should resolve the appveyor failure.

Thanks! I've scheduled a rebuild.

--

Shlomi Fish http://www.shlomifish.org/ Chuck Norris/etc. Facts - http://www.shlomifish.org/humour/bits/facts/

Right to bear arms? In Soviet Russia, we have right to whole bear. — http://is.gd/EU4puV

Please reply to list if it's a mailing list post - http://shlom.in/reply .

shlomif commented 5 years ago

Merged, thanks!