search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Add support for set_document_locator() SAX method #4

Closed 0x62ash closed 7 years ago

0x62ash commented 7 years ago

Original discussion is here - https://bitbucket.org/shlomif/perl-xml-libxml/issues/7/set_document_locator-doesnt-calls-with-xml

0x62ash commented 7 years ago

I am using quite pedantic test for locator. So it could easily fail if locator behaviour will be changed in future libxml2 releases. Maybe I should only check that locator is not null and has LineNumber and ColumnNumber?

shlomif commented 7 years ago

Thanks for the pull request. I'll try to review it soon,

shlomif commented 7 years ago

Reviewed and merged! Thanks!