search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

use ABW for better portability #45

Closed plicease closed 4 years ago

plicease commented 4 years ago

This replaces the manual logic for specifying the cflags and libs with Alien::Base::Wrapper which handles a number of corner cases better. In particular this allows me to build XML::LibXML on Visual C++ Perl on Windows.

Alien::Base::Wrapper is already part of Alien::Build (a prereq of Alien::Libxml2), so this isn't effectively a new prerequisite.

shlomif commented 4 years ago

On Mon, 09 Mar 2020 08:52:09 -0700 Graham✈️✈️ notifications@github.com wrote:

This replaces the manual logic for specifying the cflags and libs with Alien::Base::Wrapper which handles a number of corner cases better. In particular this allows me to build XML::LibXML on Visual C++ Perl on Windows.

Thanks! I'll take a look.

Alien::Base::Wrapper is already part of Alien::Build (a prereq of Alien::Libxml2), so this isn't effectively a new prerequisite. You can view, comment on, or merge this pull request online at:

https://github.com/shlomif/perl-XML-LibXML/pull/45

-- Commit Summary --

  • use ABW for better portability

-- File Changes --

M Makefile.PL (6)

-- Patch Links --

https://github.com/shlomif/perl-XML-LibXML/pull/45.patch https://github.com/shlomif/perl-XML-LibXML/pull/45.diff

--

Shlomi Fish https://www.shlomifish.org/ https://ccmixter.org/files/destinazione_altrove/49997 - “Paint The Sky”

If you have to ask what Jazz is, you'll never know. — Attributed to https://en.wikiquote.org/wiki/Louis_Armstrong

Please reply to list if it's a mailing list post - http://shlom.in/reply .

shlomif commented 4 years ago

@plicease : Merged, thanks!

plicease commented 4 years ago

Thanks for releasing this fast. I'm looking forward to testing this out in my next build of VC Perl :)

shlomif commented 4 years ago

On Wed, 11 Mar 2020 04:47:55 -0700 Graham✈️✈️ notifications@github.com wrote:

Thanks for releasing this fast. I'm looking forward to testing this out in my next build of VC Perl :)

You're welcome. Thanks for the PR.

I should note that I really dislike ms' VC for C dev: https://hamakor.org.il/pipermail/discussions/2012-October/004154.html . however, I'm planning to keep supporting it in xml-libxml for now.

--

Shlomi Fish https://www.shlomifish.org/ https://youtu.be/xZLwtc9x4yA - Anime in Real Life!! (Parody)

Happy Birthday! You'll be older than I in no time at this rate! — ED Curtis Curtis on Facebook

Please reply to list if it's a mailing list post - http://shlom.in/reply .