search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Bump minimum Perl version to 5.014 #55

Closed atoomic closed 3 years ago

atoomic commented 3 years ago

After playing with GitHub CI via #54 I doubt that you can install the whole stack of dependencies for Perl < 5.014

view build run from: https://github.com/atoomic/perl-XML-LibXML/runs/1360811754?check_suite_focus=true

We should consider bumping the minimum Perl version requirement accordingly

Grinnz commented 3 years ago

Test::TrailingSpace is only used for author tests so has no bearing on the perl requirement for installation.

Grinnz commented 3 years ago

Specifically: https://github.com/shlomif/perl-XML-LibXML/blob/master/t/style-trailing-space.t

Grinnz commented 3 years ago

To be perfectly clear: this is a very high upriver module, which is proven to work back to Perl 5.8 (http://matrix.cpantesters.org/?dist=XML-LibXML+2.0206) so I would very much object to raising the minimum version without a good reason.

atoomic commented 3 years ago

perfect if this is only a author testing thing, this is fine, let's close it

atoomic commented 3 years ago

we should consider enable CI without author testing for older versions of Perl

atoomic commented 3 years ago

I was able to confirm by adjusting the CI workflow from #54 to run the tests without AUTHOR_TESTING and tweaking t/pod-files-presence.t that everything is fine

https://github.com/atoomic/perl-XML-LibXML/actions/runs/348435636