search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Fix bug where Wrapper->mm_args value was used without considering value specified in Makefile.PL #68

Closed frboyer closed 2 years ago

frboyer commented 2 years ago

On my current compilation (on Cygwin) Alien::Base::Wrapper->mm_args contains a 'DEFINE' value of '-DLIBXML_STATIC'. The Makefile.PL was using that value without adding the required '-DHAVE_UTF8', because the hash was combined by overwriting values instead of concatenating them. It was thus failing all Unicode tests because it was compiled without the required define. With this patch it now works correctly. Note that if we would like to support concatenation of 'LIBS', it would have to be modified to work also with arrays.

shlomif commented 2 years ago

@frboyer : the changes look fine. I'll wait for the CI verdict.