search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Default value for option load_ext_dtd is 0. Default value for option expand_entities is 0 #69

Closed thibaultduponchelle closed 1 year ago

thibaultduponchelle commented 2 years ago

Reopen #48

thibaultduponchelle commented 2 years ago

@gregoa

vinc17fr commented 2 years ago

Changing the default values to 0 is not enough. All text about validation needs to be updated accordingly.

thibaultduponchelle commented 2 years ago

@vinc17fr Yes… Or we extend #70 to validation… (or am wrong?)

vinc17fr commented 2 years ago

@thibaultduponchelle Not tested, but yes, I think that it would be better to extend #70 to validation, and this would also solve #71 (unless the user shoots himself in the foot by setting validation to 1 and explicitly setting load_ext_dtd to 0 while the DTD is external).