Fix bug Node::replaceChild

[Mipu94]

Fix bug us after free in XML::LibXML::Node::replaceChild. Here is my test file. Ref: https://rt.cpan.org/Public/Bug/Display.html?id=122246

[Mipu94]

Hi Shlomi Fish, I added a regression test. Can you review it?

[shlomif]

On Thu, 13 Jul 2017 04:54:21 +0000 (UTC) sungta notifications@github.com wrote:

Hi Shlomi Fish, I added a regression test. Can you review it?

Yes, let me see.

[ppisar]

This returning NULL means an error. replaceChild() will return undef, replaceNode() will croak. While someone can consider replacing with the same node an error, I think idemponent shortcut as implemented in CPAN RT#122246 is better.

[Mipu94]

haha my very first contribution so bad :D, that patch better than mine. would you like me to commit again?

[shlomif]

@Mipu94: yes, please make another commit with a test. Sorry for the late reply.

[shlomif]

@Mipu94 : ping!

[Mipu94]

Hi Shlomif, I'm busy in this time. I will try commit ASAP. sorry for late reply.

[shlomif]

On Sun, 15 Oct 2017 05:51:07 +0000 (UTC) sungta notifications@github.com wrote:

Hi Shlomif, I'm busy in this time. I will try commit ASAP. sorry for late reply.

Thanks for letting me know.

--

Shlomi Fish http://www.shlomifish.org/ Interview with Ben Collins-Sussman - http://shlom.in/sussman

Windows Update doesn’t. — http://www.shlomifish.org/humour/bits/facts/Windows-Update/

Please reply to list if it's a mailing list post - http://shlom.in/reply .

[Mipu94]

I just made new commit.

[shlomif]

@Mipu94 : thanks - I'm going to check it.

[shlomif]

Merged, thanks! There was some trailing space and bad formatting - I fixed them.