search

shlomif / perl-XML-LibXML

The XML-LibXML CPAN Distribution for Processing XML using the libxml2 library
https://metacpan.org/release/XML-LibXML
Other
17 stars 35 forks source link

Fix test suite with libxml2 2.13.0 #87

Open nwellnhof opened 2 months ago

nwellnhof commented 2 months ago

Make the test suite work with the upcoming 2.13.0 release of libxml2.

shlomif commented 1 month ago

@nwellnhof : hi! Sorry it took me long to review this pull-request. The first issue with it is that Test::Count annotations are missing: https://metacpan.org/pod/Test::Count .

The second issue is that backward compatibility may have been broken too - including in https://metacpan.org/dist/XML-Grammar-ProductsSyndication . So I'm not sure this is the right direction.

What do you think?

nwellnhof commented 1 month ago

The first issue with it is that Test::Count annotations are missing:

I don't know how to fix this.

The second issue is that backward compatibility may have been broken too

What do you mean exactly? Did you find a regression?

shlomif commented 1 month ago

Hi @nwellnhof !

The first issue with it is that Test::Count annotations are missing:

I don't know how to fix this.

Just add "# TEST" comments to account for the new test assertions.

The second issue is that backward compatibility may have been broken too

What do you mean exactly? Did you find a regression?

Well, Perl 5 code that used to work in the past (like the one in the tests' suite or that of my ProductsSyndication module, ) stopped working. It now throws runtime errors.

nwellnhof commented 1 month ago

Just add "# TEST" comments to account for the new test assertions.

I added a "# TEST" comment for the new test and force-pushed.

Well, Perl 5 code that used to work in the past (like the one in the tests' suite or that of my ProductsSyndication module, ) stopped working. It now throws runtime errors.

The only things that have changed are error messages and bug fixes. I you found a regression, please open issue at https://gitlab.gnome.org/GNOME/libxml2/-/issues

shlomif commented 1 month ago

@nwellnhof : thanks! I'll try to investigate soon,