Closed GoogleCodeExporter closed 8 years ago
I don't mind some of this patch, but I'm not sure I like that the patch changes
the default seek positions. The values I currently use match up with the
defaults of mplayer. Any particular reason you have changed these to lower
values?
Original comment by kdeko...@gmail.com
on 9 Feb 2012 at 10:39
how am can to change them, if they are written in the code ..
no options in the settings to change them ..
Original comment by censureblock
on 10 Feb 2012 at 8:35
Then we need to make them alterable options, which will be a much larger change.
Original comment by kdeko...@gmail.com
on 10 Feb 2012 at 3:25
I took a look at your patch and decided the following things.
I did not take your change to mouse double click, because it is already in
there. If you double click button one, the screen will toggle full screen.
I did take the KP_Enter patch, the volume adjustment values for keys GDK_9 &
GDK_0
I did not change anything else for these reasons
If you want smaller values, the correct option will be to make them
configuration items. Right now the defaults match the defaults of mplayer, and
I want to keep it that way.
The other options either match up with the mplayer defaults or are decisions
that have been made in the past and at this point there is no reason to change
them.
SVN r2220 contains the changes
Original comment by kdeko...@gmail.com
on 21 Feb 2012 at 1:59
Original issue reported on code.google.com by
censureblock
on 9 Feb 2012 at 10:28Attachments: