shlyuz / implant_go

Golang Shlyuz Implant Implementation
12 stars 4 forks source link

Refactor LP and implant registration logic #1

Closed Und3rf10w closed 1 year ago

Und3rf10w commented 1 year ago

A bit of a refactor that enables us to support multiple implant and LP communication channels.

Tasks

Required

Desired

Und3rf10w commented 1 year ago

As of 4e7fb29, routine_test.go is broken, and needs to be fixed. Adding as a task.

Und3rf10w commented 1 year ago

Fixed routine_test.go being broken with https://github.com/shlyuz/implant_go/commit/2b2be80c56747e79f0b2d17974338e21b2ee94ea

Und3rf10w commented 1 year ago

Refactored LP in 86cc632. Next step is to test if we can combine the transport and/or component packages to only maintain one version of each package

Und3rf10w commented 1 year ago

Okay combining the LP and implant component and config and transport modules are absolutely possible, but would require another major refactor that would involve heavy usage of build tags to not leak functionality across components. Will mull on this some...

dd90b2a helps prepare for this by making these packages identical and more generic in functionality. Confirmed that commit didn't change functionality.

Und3rf10w commented 1 year ago

33cd670 involved a major refactor. Now both the implant and LP component share only one codebase, making everything much easier to maintain, AND paving the way for building out the teamserver

Und3rf10w commented 1 year ago

I think this is probably safe to merge going forward and move the remaining tasks into new issues