search

shm-open / code-push-server

CodePush service is an app hot update service which is compatible with react-native-code-push and other CodePush clients
MIT License
191 stars 53 forks source link

Dockerfile ${VERSION} is not being populated #148

Closed kbrownlees closed 2 years ago

kbrownlees commented 2 years ago

It does not look like the VERSION is being populated correctly when doing the docker build. I believe is is working because npm install package@just installs the latest version available.

rocwind commented 2 years ago

Good catch! Didn't realize variables defined in Makefile are not environment variables, trying to set it by: https://github.com/shm-open/code-push-server/commit/c93a4acdf14bd2bd4a4c7524c053321676ac4715

kbrownlees commented 2 years ago

@rocwind I believe you need to use something along the lines of https://github.com/cloudscapelabs/code-push-server/commit/70483ae9d59e5a1fdf4b87d48115ffffc033fb3a (with --build-var). Bit swamped at the moment so can't make a PR I am afraid.

rocwind commented 2 years ago

@kbrownlees Thanks for the example! I'll have a try

rocwind commented 2 years ago

It should be addressed by https://github.com/shm-open/code-push-server/commit/0619e4ec399714095f9b30a136b1808c7642a04e, closing this issue.