search

shnewto / bnf

Parse BNF grammar definitions
MIT License
261 stars 23 forks source link

serde dependency has no feature flag #149

Closed Carlyle-Foster closed 5 days ago

Carlyle-Foster commented 6 days ago

since serde is just being depended on for trait implementations it should be behind a feature flag.

i could submit a pull request for this if you want, i'm just unsure about whether this should be a default flag and whether i missed some sneaky implicit dependency on serialize/deserialize in my skimming of the source.

Carlyle-Foster commented 5 days ago

i've tested the change locally and all the tests pass with serde disabled, for now i think we should have serde as a default feature flag so we can push the change as a patch. i think it should be removed from the default on the next major version, but that's just my 2 cents.