Impl from string - Githubissues

shnewto / bnf

Parse BNF grammar definitions

MIT License

258 stars 22 forks source link

Impl from string #23

Closed CrockAgile closed 7 years ago

CrockAgile commented 7 years ago

Closes #22 and #12 by implementing std::str::FromStr for the node types.

Also removed look_ahead! in favor of not maintaining a separate macro when it seems like nom::recognize! offers similar behavior.

⚠️ do not merge: tests to be added

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 91.667% when pulling 2a052852e607e1d58dab6b858bf5ed111bb2b567 on impl-from-string into c0406bb8c25627c37b1148409f3e23c6102d04be on 0.2.0-devel.

shnewto commented 7 years ago

I really like this, it represents a really great addition and also appreciate your approach to those areas you refactored. Once the tests are filled in I'm ready to approve.

coveralls commented 7 years ago

Coverage decreased (-1.4%) to 90.72% when pulling 046e0a14d4dcc5f646f0d23d1fddbf86346ff726 on impl-from-string into c0406bb8c25627c37b1148409f3e23c6102d04be on 0.2.0-devel.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 93.548% when pulling 3601e84a1b578c8af09653d52943c3f0130e8f0e on impl-from-string into c0406bb8c25627c37b1148409f3e23c6102d04be on 0.2.0-devel.

coveralls commented 7 years ago

Coverage increased (+1.4%) to 93.537% when pulling b01538e6f7c4d59a56f6187f88ddd096961ac3f8 on impl-from-string into c0406bb8c25627c37b1148409f3e23c6102d04be on 0.2.0-devel.

shnewto commented 7 years ago

Working on failing tests, will PR again once that development is closer to complete.