search

shnewto / bnf

Parse BNF grammar definitions
MIT License
256 stars 22 forks source link

Use `slice::iter` instead of `into_iter` to avoid future breakage #48

Closed z2oh closed 4 years ago

z2oh commented 4 years ago

an_array.into_iter() currently just works because of the autoref feature, which then calls <[T] as IntoIterator>::into_iter. But in the future, arrays will implement IntoIterator, too. In order to avoid problems in the future, the call is replaced by iter() which is shorter and more explicit.

A crater run showed that your crate is affected by a potential future change. See https://github.com/rust-lang/rust/pull/65819 for more information.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.3%) to 93.093% when pulling 12bb69546fbad21419d4ce2f7c0504773b6c746b on z2oh:master into dc11fcc1ee4ffb982467d9e9c576df6fea1f1e1a on shnewto:master.

shnewto commented 4 years ago

That's really good to know! 👀

Thanks a ton for helping out and making a PR!