search

shnewto / bnf

Parse BNF grammar definitions
MIT License
256 stars 22 forks source link

Phase out old nom macros #50

Closed shnewto closed 4 years ago

shnewto commented 4 years ago

Went through all of the old nom style macros implemented and took a nom 5 approach, using only functions. Some fall out from that included simplifying our error reporting, I'm not even sure why we were differentiating parse from incomplete errors in the first place...

Another part of these changes is tackling a bunch of stuff clippy warned about. The most significant change there was removing the weirdness where I was implementing FromStr for each object as well as a from_str in each object's impl. Now instead of seeing let x = Object::from_str("..."), we're using let x: Result<Object,_> = "...".parse()

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.4%) to 92.409% when pulling d4d85f68598daa7ca7b2280b19b0edb54fe3bd79 on phase-out-old-nom-macros into 78d25a6e8b4adfc74652bc77549cdcd2fb04ed3a on master.