SKalt commented 3 years ago

This should partially address the suggestion in #79, splitting the longish, more escape-heavy bnf test fixtures into their own .bnf files. I decided against extracting the DNA example since it's short and emoji-based bnf examples since I didn't feel the effort would make reading the tests easier.

shnewto commented 3 years ago

Hi @SKalt, happy to see the newline fix worked 😄

I updated the action that's failing for you and it's on main now, would you mind syncing w/ that and pushing it up again? I'm not particular about history so no need for anything more than pulling in the update and pushing it back up here (unless you have another flow/preference, then don't let me stop ya)

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (701c1c7) into main (b824466) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          10       10           
  Lines         792      792           
=======================================
  Hits          721      721           
  Misses         71       71

Impacted Files	Coverage Δ
tests/grammar.rs	`81.25% <ø> (ø)`
tests/display.rs	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b824466...701c1c7. Read the comment docs.

shnewto commented 3 years ago

@SKalt thanks so much!

shnewto / bnf

chore: factor long bnf text fixtures into their own files #80

Codecov Report