sho-87 / kanagawa-paper.nvim

Remixed Kanagawa colourscheme with muted colors. For Neovim.
MIT License
72 stars 2 forks source link

[FEAT] : Add support to mini.completion #4

Closed Yushi5058 closed 2 months ago

Yushi5058 commented 2 months ago

Hello, I would like to suggest to add support for the mini.completion plugin so it has consistent colors the same as the colorscheme. Current Output 2024-06-26_21-26-32 Thanks for the awesome work, Yushi

sho-87 commented 2 months ago

@Yushi5058 do you mean consistent colors as in the keywords like function being the same color as in the buffer? ive not looked into it too much, but I believe that is quite difficult to do as I think pmenus use the same highlight group for text (but unsure)

also, what font are you using? looks nice

sho-87 commented 2 months ago

so for example, this is how it works on my setup (and most setups ive seen):

image

Yushi5058 commented 2 months ago

@Yushi5058 do you mean consistent colors as in the keywords like function being the same color as in the buffer? ive not looked into it too much, but I believe that is quite difficult to do as I think pmenus use the same highlight group for text (but unsure)

Maybe you can see that with the plugin author echasnovski, and there are some merge prs he did for some colorschemes to include his plugin support.

also, what font are you using? looks nice

I use maple-font, thanks

Yushi5058 commented 2 months ago

so for example, this is how it works on my setup (and most setups ive seen):

  • the documentation on the right is syntax highlighted
  • the type is also correctly highlighted (same as buffer)
  • but the name itself is not and is all just the fujiWhite color like regular text

image

That's certainly my desired output for the completion plugin I use. It works good on mini.statusline but not on the completion

sho-87 commented 2 months ago

just installed mini.completion to test it out. doesnt seem like there are docs or item type/kind available in the plugin. are you referring to the bright blue background? image

that is easy enough to change to image

or

image

sho-87 commented 2 months ago

(just pushed an update to change the bright blue)

Yushi5058 commented 2 months ago

Thank you !