Can't disable mp_overtime_enable, because plugin enables it when match goes live

shobhit-pathak / MatchZy

MatchZy is a plugin for CS2 (Counter Strike 2) for running and managing practice/pugs/scrims/matches with easy configuration and Get5 (G5API/G5V) support as well!

https://shobhit-pathak.github.io/MatchZy/

MIT License

220 stars 55 forks source link

Can't disable mp_overtime_enable, because plugin enables it when match goes live #137

Closed borzaka closed 1 month ago

borzaka commented 2 months ago

During group stage matches, it's very common that matches can end up tie, and won't go to overtime. But the plugin enables overtime, no matter what. Disable it in the live.cfg won't help, because this code is executed after the live.cfg:

https://github.com/shobhit-pathak/MatchZy/blob/6042de1d1f425a4620c1283d9ec9283ab3e6cf05/Utility.cs#L255

Possible solutions:

remove the above mentioned line from the code (PugSetup does the same)
add a new .cfg file to execute after the above code

shobhit-pathak commented 2 months ago

Hey!

Thanks for pointing it out and apologies for missing it, silly of me. I'll fix this in the next update, I should probably read its value from the live.cfg rather than hardcoding it like this.

Thanks!

shobhit-pathak commented 1 month ago

Hey!

This is now fixed with the 0.7.11 release. We now read the mp_overtime_enable and mp_match_can_clinch from live.cfg

Thanks!

borzaka commented 1 month ago

Thank you!

One question: What happens when I have multiple mp_overtime_enable setting in my live.cfg? I like to keep the original live.cfg untouched, and put my custom variables at the bottom.

live.cfg

...
mp_overtime_enable 1
...

// My custom variables
mp_overtime_enable 0