search

shobhit-pathak / MatchZy

MatchZy is a plugin for CS2 (Counter Strike 2) for running and managing practice/pugs/scrims/matches with easy configuration and Get5 (G5API/G5V) support as well!
https://shobhit-pathak.github.io/MatchZy/
MIT License
244 stars 67 forks source link

Add full support for Get5 `get5_status` spec #93

Closed The0mikkel closed 6 months ago

The0mikkel commented 7 months ago

Add full support for Get5 get5_status spec.

This updates the current get5_status command, to respond with the full Get5 schema for the command. This complements #86

I want to note, that I have not fully tested it, but I have run a small wingman tournament with it. Had some issues testing, due to the knife round bug.

I am very sorry for the split update on get5_status

shobhit-pathak commented 7 months ago

Hey!

Thanks a lot for the PR and your work :D

Apologies for not including this PR in 0.7.0 version, as that update was already ready to be pushed. But I'll test it and release it in the next update, that is, 0.7.1 :D

Thanks!

The0mikkel commented 7 months ago

Amazing! You're welcome :D

It definitely needs some testing, as the updates changes some small items in the rest of the codebase.

shobhit-pathak commented 7 months ago

Hey! Could you please check the conflicts? I had made some minor changes, like fixing naming of the function hence the conflicts in this PR

The0mikkel commented 7 months ago

Thank you for highlighting the conflict.
I will try to take a look at it later today.

The0mikkel commented 6 months ago

Just as an update, the update should be ready. It has been tested at a LAN party event, but I haven't tested it with the advanced practice setup (where I tested the practice commands, with this version).