search

shobhitpuri / custom-google-signin-button

A custom SignInButton for Android that supports 'android:text' attribute, currently not supported by Google's original 'SignInButton'. This library also allows to set button theme to dark or light and is based on Google guidelines.
http://go.shobhitpuri.com/googlesignin
MIT License
78 stars 25 forks source link

Added ability to center the text in the button #6

Closed shobhitpuri closed 5 months ago

shobhitpuri commented 5 years ago

Allow centering text within the whole button instead of just the space other than Google icon. This resolves #3

shobhitpuri commented 5 years ago

Thanks for reviewing. Its just I've to release the 1.1.0 version before merging this. I'll merge it after releasing.

manojahi commented 2 years ago

What is the status of the PR? its been in this state for a long time. I really really want to have this in my app.

shobhitpuri commented 2 years ago

What is the status of the PR? its been in this state for a long time. I really really want to have this in my app.

Haven't been getting time to fix conflicts and test the changes. Feel free to do them, and I can look at the PR :)