search

shobhitsharma / embedo

Embeds third party content to DOM with perks 🧙‍♀️ (7kb gzip / standalone)
https://shobhitsharma.github.io/embedo
MIT License
347 stars 32 forks source link

spotify support #15

Closed KiddoKenshin closed 5 years ago

KiddoKenshin commented 5 years ago

Spotify's oembed is undocumented. Also, there are some core changes in order for spotify to work.

Please check the inline comment :)

shobhitsharma commented 5 years ago

@KiddoKenshin You might not need to do that, because spotify embed URLs are publically allowed to embed. By default embedo's fallback iframe service will embed it. See https://codepen.io/shobhitsharma/pen/prOGzd

KiddoKenshin commented 5 years ago

My apologies blush Thank you for pointing it out :)

I close this PR m( )m