Override SDK via options

shobhitsharma / embedo

Embeds third party content to DOM with perks 🧙‍♀️ (7kb gzip / standalone)

https://shobhitsharma.github.io/embedo

MIT License

348 stars 32 forks source link

Override SDK via options #19

Closed Iliyass closed 4 years ago

Iliyass commented 4 years ago

First of all, thanks for this library, it saved me a lot of time and the integration process was seamless.

I had a use case, where I use facebook SDK for analytics, and I end up loading two different Facebook SDKs, we use sdk.js and embedo uses all.js which I think it was deprecated, and it was throwing an exception where FB.AppEvents was undefined.

Solution: Provide the SDK URL from options

shobhitsharma commented 4 years ago

Nice, though I updated it to lowercase sdk in version v1.13.0