search

shobhitsharma / embedo

Embeds third party content to DOM with perks 🧙‍♀️ (7kb gzip / standalone)
https://shobhitsharma.github.io/embedo
MIT License
348 stars 32 forks source link

embedo dosen't work now, FB/IG seemd change the API #25

Closed farwod closed 3 years ago

farwod commented 3 years ago

hi I find fb update their API, so could you upgrade base on the new version? FYI https://developers.facebook.com/docs/instagram/oembed-legacy/

thanks a lot

sharafuvyt commented 3 years ago

Please upgrade the version with the fixes

max-dombrowski commented 3 years ago

Hi, would be very nice if you can make a new release to support the newest facebook and instagram api. Feel free to contact me if we can help. Big thx

tomdracz commented 3 years ago

Looks like app id & access tokens are now required so will be higher barrier to entry. Would be happy to take a stab at PR but so far, I can't seem to get test suite to pass. Every case apart from embedding a video fails, seemingly because load event is never emitted 🤷

shobhitsharma commented 3 years ago

Thanks for reporting. I will look into it in evening, and update oembed URLs and specs.

shobhitsharma commented 3 years ago

I've tested and release new minor version for facebook and instagram embeds, only thing which needs to be done is just add access_token once to global init options as described here https://github.com/shobhitsharma/embedo/releases/tag/v1.14.0

See https://github.com/shobhitsharma/embedo/pull/26 for screenshots and changes I've made.

shobhitsharma commented 3 years ago

demo: https://codepen.io/shobhitsharma/full/prOGzd

congnk commented 3 years ago

it seem that the demo site haven't be updated? https://shobhitsharma.github.io/embedo/