search

shoes / furoshiki

Distribute Ruby GUI apps easily.
https://github.com/shoes/furoshiki
Do What The F*ck You Want To Public License
36 stars 6 forks source link

Extract shoes #14

Closed wasnotrice closed 9 years ago

wasnotrice commented 9 years ago

Here's a solution for our circular dependency problem. Also modified to use the new Shoes gem structure. Requires changes to Shoes in shoes/shoes4#989 that haven't been merged to master yet.

The idea here is for furoshiki to be a generic packager and inject anything project/platform specific. So all of the Shoes-specific code has been removed, and we're left with a packager that can wrap up Ruby code in a .jar or in a .app. There are specs for a Ruby "Hello World" jar, but the app specs are a bit lacking.

I envision the Shoes code that has been removed from this gem living in a shoes-packaging gem with the rest of the Shoes code. That way, furoshiki has no dependency on Shoes, and it's the responsibility of shoes-packaging to make sure we have shoes-core available for packaging.

As I worked through this, I realized that we may want the ability to package gems that aren't installed locally as well...but I'm leaving that alone for now.

Thoughts? @jasonrclark @PragTob @KCErb ???

PragTob commented 9 years ago

Big :+1: on the overall idea and direction of this. Everything else - I'm reviewing right now :)

{S: What a flurry of PRs and stuff, happy about them and trying to catch up! =)

PragTob commented 9 years ago

Looks good, thank you very much Eric!

Quite some comments, but they are all minor and mostly style questions about naming, method length and other stuff :) I'm sure this also hit code that's not really part of this move but was just relocated, feel free to ignore them!

Looks like a great step forward for furoshiki! Thanks and happy holidays!

wasnotrice commented 9 years ago

OK I think I've address most of @PragTob excellent suggestions. Putting off default icons and downloading for now. I have a feeling that at some point we will have to commit to having a proper endpoint for downloading templates if packaging is really going to work well.

Didn't adjust the version yet.

So I think this is ready for merge if you all agree. :rocket:

jasonrclark commented 9 years ago

Looks good to me, but @PragTob did have more to mention so I'd probably wait for him to take a look.

Are you starting in on the other side of things? I haven't yet, although I might do within the hour if certain small peope stay down for their naps :boy: :zzz: ... but don't want to dup effort with you @wasnotrice.

Thanks again for picking this up! So much better than what I was going to be able to do with my limited knowledge of packaging.

PragTob commented 9 years ago

Looks good to me, thanks for all the great work @wasnotrice ! :+1: :) :) :)

jasonrclark commented 9 years ago

Hehe, so looks like looking at the related side won't be happening shortly ¯(ツ)/¯ Will ping back on shoes/shoes4#989 if I do get time enough later today to make any of those modifications.