shoes / furoshiki

Distribute Ruby GUI apps easily.
https://github.com/shoes/furoshiki
Do What The F*ck You Want To Public License
36 stars 6 forks source link

Write archives from packaging #33

Closed jasonrclark closed 7 years ago

jasonrclark commented 7 years ago

This PR revises furoshiki to write out archive files as its output (tar.gz for Mac and Linux, zip for Windows) rather than loose files in directories. In addition to being a nice-to-have for users, this addresses the problem from https://github.com/shoes/shoes4/issues/1448 because the tar retains executable permissions even when built on Windows.

Other highlights:

TODO:

jasonrclark commented 7 years ago

Great comments @PragTob, and thanks for taking a look! I've decomposed and renamed through the create_archive method quite a bit and I like how it ended up much better. Review FTW 💖

Won't get to testing much tonight, but hoping this weekend to get some relaxing Shoes time in which to button up the next release.