Shoes installer overwrites PATH in Windows

shoes / shoes-deprecated

Former repo for Shoes... see README for up to date locations!

http://shoesrb.com/

Other

1.15k stars 168 forks source link

Shoes installer overwrites PATH in Windows #271

Open Chia-KY opened 9 years ago

Chia-KY commented 9 years ago

shoes-3.2.18-gtk2-32.exe installation in Windows 8.1 x64 overwrites environment PATH with ONLY shoes directory. All previous paths are overwritten.

ccoupe commented 9 years ago

I'm sorry to hear that. I un-install/install shoes two or three times a week on Win7 and haven't seen this problem. I know it was tested by others on 8.1. Do you have other applications that set the path? Perhaps shoes is conflicting with them?

IanTrudel commented 9 years ago

Known issue with the version of NSIS used. Read Where's the large string version of the Unicode NSIS? http://www.scratchpaper.com/home/faq

Solution: either use Unicode NSIS or rebuild NSIS with large strings as per the instructions here — http://nsis.sourceforge.net/Special_Builds

ccoupe commented 9 years ago

I've fixed this (NSIS now has longer strings) and tested it, @Chia-KY There's a beta build of Shoes 3.2.19 that has this fix at http://walkabout.mvmanila.com/public/shoes/shoes-3.2.19-gtk2-32.exe Please don't use the Advanced Packaging in the beta.

IanTrudel commented 9 years ago

TESTING SCENARIO

Save %PATH% either from command line or in Control Panel;
Add paths to the %PATH% with the GUI until you reach over 1024 characters;
Install Shoes with the installer created using your patched NSIS;
Check %PATH% again, should have kept everything because of the patch;
Uninstall Shoes, check the %PATH% again.
Restore %PATH% in GUI from the first step.