search

shoes / shoes3

a tiny graphical app kit for ruby
http://walkabout.mvmanila.com
Other
181 stars 19 forks source link

had some warnings in shoes/console/gtk-terminal.c #139

Closed passenger94 closed 9 years ago

passenger94 commented 9 years ago

@ccoupe relevant changes only in gtk-terminal.c see if you're interested in those changes

we can delete the pull request afterwards

ccoupe commented 9 years ago

I suspect some of those are from my merging of the console branch into master along with whatever was unsync-ed or maybe you haven't synced in a while?. I've add those commits to master, modified a few (and told you about them). I don't know git very well so it could be my error.

passenger94 commented 9 years ago

i didn't synced for a while indeed (i think i have to do a git rebase or something ), that's why i made this PR only for you to see the changes i made in gtk-terminal.c where i have those gtk warnings from your very recent changes, the PR is a temp action to be erased when you checked those changes (only the ones in gtk-terminal.c : last 2 commits, - totally not intended to do a merge pull request -) unless i didn't understood :-)

ccoupe commented 9 years ago

Your changes to gtk-terminal.c have been pushed to master. Thank you.