search

shoes / shoes3

a tiny graphical app kit for ruby
http://walkabout.mvmanila.com
Other
179 stars 19 forks source link

Windows Path Destroyed #421

Open DACN opened 5 years ago

DACN commented 5 years ago

I have just installed shoes (shoes-3.3.6-gtk3-32.exe) on windows 10. In doing so, it has just destroyed the Path environment variable, leaving shoes at the only entry. The installation of a tonne of other programs destroyed by installing shoes.

ccoupe commented 5 years ago

Damn! That problem was fixed a few years ago. It must have come back. So Sorry!

FWIW, it's likely to be the NSIS installer was built w/o 'long string' support.

DACN commented 5 years ago

Yes - for some reason the 'default versions' of NSIS which you download do not have long string support. You need to look slightly more carefully to get one with long string support. So, agree - that is a very plausible cause.

D

On Fri, 7 Dec 2018 at 03:06, Cecil Coupe notifications@github.com wrote:

Damn! That problem was fixed a few years ago. It must have come back. So Sorry!

FWIW, it's likely to be the NSIS installer was built w/o 'long string' support.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shoes/shoes3/issues/421#issuecomment-445107761, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ5TotHtYJOywHmiLEqhy9O4gN5uSbp2ks5u2dswgaJpZM4ZHe5i .

ccoupe commented 5 years ago

FWIW, I've tested Shoes 3.3.7 (beta) and it cut off a path that was roughly 2700 bytes long. That's with the long string patch (supposedly). How big was your path, @DACN ?

ccoupe commented 5 years ago

Interesting backaground. If I understand it, 2048 characters is the practical limit, and you'd want to be a bit less than that.

ccoupe commented 5 years ago

Fixed. If the PATH + addition > NSIS_MAX_STRLEN then user will get a warning and the path won't be modified. That works even if the big string patch is not used.

DACN commented 5 years ago

Thanks

David

On Sun, 13 Jan 2019 at 06:21, Cecil Coupe notifications@github.com wrote:

Fixed. If the PATH + addition > NSIS_MAX_STRLEN then user will get a warning and the path won't be modified. That works even if the big string patch is not used.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shoes/shoes3/issues/421#issuecomment-453805643, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ5ToukRzJ_itlL93OPbp0yS6t_mfhy2ks5vCtBsgaJpZM4ZHe5i .

Ryokai96 commented 4 years ago

I have just installed (shoes-3.3.7-gtk3-32.exe) on Windows7 and Windows10, it have the same problem, I haven't got warning and my windows path has modified. Fix it, please.

ccoupe commented 4 years ago

@Ryokai96 - Sorry for the difficulty. It must be an off-by-one problem. Be aware the Shoes is no longer being maintained so this problem is unlikely to be fixed.