shogerr / bluprntr

Prints your Bluprints to disk
11 stars 2 forks source link

Uncaught TypeError: Cannot read property 'query' of undefined #3

Closed lisaanncassidy closed 4 years ago

lisaanncassidy commented 4 years ago
Screenshot 2020-06-04 at 14 12 01

This absolutely might be user error, but the above is occurring every time I clear and attempt to start again

The designated download path contains nothing, and it isn't entirely clear to me what I should be seeing in the network tab following clicking the video.

Thank you for your development work, I'd love to get this running!

shogerr commented 4 years ago

Thanks for the feedback! I'll put up a video in the README that shows what the output should look like in the server. I've attached a screenshot of a powershell context open in VSCode with the server running in the mean time.

That's a real interesting error there, because it implies that chrome.tabs is completely undefined. Could I get your OS and browser version?

image

shogerr commented 4 years ago

I think today I will work on a new tab query routine. The change will be to query all the tabs and filter by the open url. Right now, only the active tab is sought by the extension. I think I will make this method selectable by the user. That should be more robust, but a little slower.

lisaanncassidy commented 4 years ago

Thanks! Chrome - Version 83.0.4103.61 (Official Build) (64-bit) OS - OS X 10.15.5 (Catalina)

shogerr commented 4 years ago

@lisaanncassidy I just added more permissions to the extension. They shouldn't be necessary with the version of Chrome that we're both using, but it can't hurt.

{
  "manifest_version": 2,
  "name": "BluPrntr",
  "version": "0.1",
  "permissions": [
    "declarativeContent",
    "storage",
    "tabs",
    "<all_urls>",
    "activeTab",
    "http://*/*",
    "https://*/*"
  ],
  ...
}

Try using the updated code... it may help, but maybe not. The error you are encountering is not one I would expect. It happens, but only if the programmer is trying to query tabs from say, a content script, which isn't the case here.

Can you also try removing the extension completely, closing chrome, re-opening chrome and adding the extension back? I haven't been able to reproduce your problem specifically, so best to try to reload everything completely.

lisaanncassidy commented 4 years ago

This seems to have done the trick, thank you!