search

shogo82148 / androidbinary

Android binary file parser written in golang
MIT License
241 stars 79 forks source link

add ScreenOrientation for AppActivity #34

Closed gitig closed 4 years ago

codeskyblue commented 4 years ago

example test need fix

Sent with GitHawk

gitig commented 4 years ago

The expected ScreenOrientation exists. https://github.com/shogo82148/androidbinary/blob/492d2f4eb32b3de04dfa2e648a37169c7381531b/xml_test.go#L83

but wanted xml not exist https://travis-ci.org/shogo82148/androidbinary/jobs/578498716#L302

can u help me ?

shogo82148 commented 4 years ago

For historical reasons, there are two definitions of the Android Manifest. One is for users, another is for tests.

https://github.com/shogo82148/androidbinary/blob/492d2f4eb32b3de04dfa2e648a37169c7381531b/apk/apkxml.go#L94-L102

https://github.com/shogo82148/androidbinary/blob/492d2f4eb32b3de04dfa2e648a37169c7381531b/xml_test.go#L12-L19

I'll fix the test after merging. Thank you!