search

shogun-toolbox / shogun-web

Shogun Website
5 stars 7 forks source link

fix security #13

Closed zhengyang92 closed 11 years ago

zhengyang92 commented 11 years ago
  1. splitup the demos.py into individual ones.
  2. changed the way of demo handling, which is more optimized for security.
  3. fix the svr demo bug.
sonney2k commented 11 years ago

I've had a more thorough look at what you've done. And have some more feedback:

  1. Don't import more than you need. Don't import * at all
  2. The importlib stuff really is not needed. You can achieve the same by modifying urls.py
  3. The code really is much more readable now that you've split it up into multiple functions/classes
sonney2k commented 11 years ago

I will merge it nevertheless and do the changes I have in mind to give you and idea. Please have a close look on that then again.

zhengyang92 commented 11 years ago

I've had a close look at it, and knew what you mean. I'll do as you said and make the code as security as possible.