search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Unify bundle solvers #1969

Open vigsterkr opened 10 years ago

vigsterkr commented 10 years ago

currently there are 4 different bundle solvers in shogun:

src/shogun/structure/libbmrm.cpp
src/shogun/structure/libncbm.cpp
src/shogun/structure/libppbm.cpp
src/shogun/structure/libp3bm.cpp

these implementations share quite amount of code, so first it would be great to unify them, i.e. reduce code redundancy and as well it could be a good guinea pig to start designing an optimization framework in

src/shogun/optimization/
sandeepkc commented 10 years ago

Hi @vigsterkr,

I have started working on this. I hope it is all right. Thanks, Sandeep !

vigsterkr commented 10 years ago

@sandeepkc yes but it'd be ideal to discuss your plan/ideas before you seriously start to work on this.

sandeepkc commented 10 years ago

Hi Viktor,

Thanks for the quick reply !

Though I started with Shogun with 'Fundamental Machine Learning algorithms' in mind, while reading about other tasks I got interested in 'LP/QP Optimization Framework' as I have experience with Linear Programming and Quadratic programming, and I implemented some LP/QP solvers during an optimization course in my undergrad. This is the reason I wanted to get started with 1969 as it is starting point for creating an optimization framework. Please let me know what you think.

Thanks, Sandeep.

On Tue, Mar 11, 2014 at 12:23 AM, Viktor Gal notifications@github.comwrote:

@sandeepkc https://github.com/sandeepkc yes but it'd be ideal to discuss your plan/ideas before you seriously start to work on this.

Reply to this email directly or view it on GitHubhttps://github.com/shogun-toolbox/shogun/issues/1969#issuecomment-37269210 .

Thanks and regards, Sandeep K Chaudhary.

vigsterkr commented 10 years ago

@sandeepkc think about what exactly?

sandeepkc commented 10 years ago

@vigsterkr,

Whether it is a good idea for me to start working on this ticket?

vigsterkr commented 10 years ago

@sandeepkc the only person who can tell this is yourself.

sandeepkc commented 10 years ago

@vigsterkr ok. I think I will work on this then. Thanks !

vigsterkr commented 10 years ago

@sandeepkc that's great! but as i stated earlier before you start to put serious coding work into this it would be great to discuss how do you plan to solve this problem as serious design decisions have to be made during this task.

sandeepkc commented 10 years ago

@vigsterkr ok, I see. Then I have to get more details about the routines in these four files so that I would be in a better position to present my case. Please give me some time, and I would get back with my thoughts on the design so that it can be discussed.

vigsterkr commented 10 years ago

@sandeepkc yeah that's alright take your time..

pts95 commented 10 years ago

@vigsterkr I have already started working on this -kprah

vigsterkr commented 10 years ago

@akpraharaj that's great! would be great to share some of your ideas... before starting do to serious coding...