search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

refactor SingleLaplacianInferenceMethodWithLBFGS and SingleLaplacianInferenceMethod #3154

Closed yorkerlin closed 8 years ago

yorkerlin commented 8 years ago

@karlnapf https://github.com/shogun-toolbox/shogun/wiki/GSoC_2016_project_large_gps

karlnapf commented 8 years ago

Can you give some more specifiy instructions here, so that somebody else would be able to do this? Not clear what this issue is about with this description

yorkerlin commented 8 years ago

SingleLaplacianInferenceMethod uses Newton method. SingleLaplacianInferenceMethodWithLBFGS uses LBFGS method. The issue is about refactoring these two methods using strategy pattern.

Hint: One class and two optimizers (Newton optimizer and LBFGS optimizer)

yorkerlin commented 8 years ago

@karlnapf done! I will send PRs to address this issue.

yorkerlin commented 8 years ago

https://github.com/shogun-toolbox/shogun/pull/3168