Support for Combined and String features in trees

shogun-toolbox / shogun

Shōgun

http://shogun-toolbox.org

BSD 3-Clause "New" or "Revised" License

3.03k stars 1.04k forks source link

Support for Combined and String features in trees #3626

Open vigsterkr opened 7 years ago

vigsterkr commented 7 years ago

Currently all the tree implementations, C4.5, CHAID, CART, requires the input feature to be in CDenseFeatures<float64_t>, which is... well not that optimal to say the least. :)

it'd be great that we at least add support for:

but as well would be great that we use not support float64_t features for DenseFeatures.

karlnapf commented 7 years ago

See #3313 for an example for such a patch

djokester commented 7 years ago

Can I take this up?

karlnapf commented 7 years ago

Yeah do it !

MikeLing commented 7 years ago

Hi @djokester , are you working on it right now? I would like to add this feature to kd-tree and cover-tree if it's ok due to I'm working on the KNN right now. However, I'm totally ok to forget this issue if you had already have some progress on it. Thank you :)