search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

add PR preview build #3793

Open karlnapf opened 7 years ago

karlnapf commented 7 years ago

To buildbot, just like the cookbook preview we already have.

It would be good to have previews of

This will make reviewing much easier, in addition to giving as a test for the notebooks on PR level

Has to be done by core dev with buildbot access, so either of @karlnapf @iglesias @lisitsyn @vigsterkr

Fernando, we discussed this, so I assigned you

iglesias commented 7 years ago

Sure, I'll take care of it :+1:

iglesias commented 7 years ago

I thought a bit further about the notebooks preview for PRs. For the actual previews/visualizations of the notebooks, I came up with creating a github repo where the notebooks with the cells' outputs will be pushed.

PRs can be organized in branches or the dir structure of the repo. Once a PR is merged, the corresponding branch/directory is removed.

Thoughts on that? @vigsterkr @karlnapf

karlnapf commented 7 years ago

I think all this can be done via the buildbot API in fact. Can copy to the webserver Best to discuss together with @vigsterkr on slack I think

iglesias commented 7 years ago

Yeah, using the webserver sounds good too.