search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Check and enforce minimal ctags version in cmake #4124

Open syashakash opened 6 years ago

syashakash commented 6 years ago

During installation, make throws error :

[ 85%] Generating tags /usr/bin/ctags: unrecognized option '--c++-kinds=cgp' Try/usr/bin/ctags --help' for a complete list of options. src/shogun/CMakeFiles/ctags.dir/build.make:60: recipe for target 'src/shogun/tags' failed make[2]: [src/shogun/tags] Error 1 CMakeFiles/Makefile2:206: recipe for target 'src/shogun/CMakeFiles/ctags.dir/all' failed make[1]: [src/shogun/CMakeFiles/ctags.dir/all] Error 2 Makefile:149: recipe for target 'all' failed make: *** [all] Error 2 `

GNU Make 4.1

Exuberant Ctags 5.8

cmake version 3.5.1

Ubuntu 16.04

Any solutions to resolve this?

karlnapf commented 6 years ago

What is your ctags version? Is it exuberant-ctags?

You can always disable the meta examples via -DBUILD_META_EXAMPLES=Off to side-step.

syashakash commented 6 years ago

Exuberant Ctags 5.8 Yes it is exuberant-ctags. cmake -DBUILD_META_EXAMPLS=OFF worked. Thank you I wonder why did this happen though. Is it because of ctag or cmake or some other reason!

karlnapf commented 6 years ago

It is probably this version doesn’t support the argument that it moaned about. This is something we should check in cmake, ie find out in which version the flag was introduced and then make sure that cmake checks for at least this version

Good entrance task that will involve using google to find out details

luisffranca commented 6 years ago

I've used '--c++-kinds=cgp' with Exuberant Ctags 5.8 and it worked.

@syashakash Could you, please, show us the output for ctags --version in your OS?