Open karlnapf opened 6 years ago
I would like to work on this issue, Does it involve changing anything else other than line 514 and 523 in kernel.h and should i replace them as same as you described above and send a pr ?
it involves doing these changes and then checking whether they break anything. This involves reading the code, thinking, and running the tests. Please check here how to get started: https://github.com/shogun-toolbox/shogun/wiki/Getting-involved
@karlnapf I'm not able to perform all the tests, can you please help me out!!
Hello @divyanshu132 I am working on this issue if u don't mind can you please leave this issue to me ?, i will let u know if i am not able to fix this
@vishal3410 no problem, it's completely fine!!
The field only causes problems. This is a refactoring exercise to remove the fiels, and instead query the underlying features.
Special cases might be
CCustomKernel
where no features are set. However, the base class should always query the underlying features.The member function
would be changed to
or similar. Obsiously, the same should be for
num_rhs