search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Refactor LinearMachine #5089

Closed LiuYuHui closed 4 years ago

LiuYuHui commented 4 years ago
gf712 commented 4 years ago

@LiuYuHui what did you remove in the Classification notebook? The diff seems to be too large to display on GitHub

LiuYuHui commented 4 years ago

@LiuYuHui what did you remove in the Classification notebook? The diff seems to be too large to display on GitHub

I removed the output of notebooks.

karlnapf commented 4 years ago

This is it?

karlnapf commented 4 years ago

checks passed. Anything missing?

LiuYuHui commented 4 years ago

@gf712 should i add LinearMachinePredictor in this PR?

gf712 commented 4 years ago

Maybe can do that in a pr against develop. Shall I merge this?

LiuYuHui commented 4 years ago

Maybe can do that in a pr against develop. Shall I merge this?

sure :D

gf712 commented 4 years ago

can you also update the gpl commit hash? I think it is not pointing to the latest changes in the shogun-gpl pr

gf712 commented 4 years ago

last minor things and then can merge!

gf712 commented 4 years ago

Great! What's next? :)

LiuYuHui commented 4 years ago

Great! What's next? :)

MulticlassMachine :D