shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Add meta example for isomap converter. #5106

Closed Hephaestus12 closed 3 years ago

karlnapf commented 4 years ago

seems ok, please change the fname though

geektoni commented 4 years ago

There seems to be an issue when testing the new meta example on the integration data (unrelated to the merge conflict). @Hephaestus12 maybe you pushed a different file and then the test does not pass on the CI?

Hephaestus12 commented 4 years ago

This is where the CI is failing https://dev.azure.com/shogunml/shogun/_build/results?buildId=3960&view=logs&j=be3b03d7-4089-5ab3-9462-9af4d8b1dcdf&t=92f9e07a-f827-5326-7f00-9de226b0894b&l=1470

But when I run this test on my machine it works: https://pastebin.com/fgVBEfri

Why might that be? Also, I don't understand why the merge conflict, I have added just one new file.

geektoni commented 4 years ago

This is where the CI is failing https://dev.azure.com/shogunml/shogun/_build/results?buildId=3960&view=logs&j=be3b03d7-4089-5ab3-9462-9af4d8b1dcdf&t=92f9e07a-f827-5326-7f00-9de226b0894b&l=1470

But when I run this test on my machine it works: https://pastebin.com/fgVBEfri

Why might that be? Also, I don't understand why the merge conflict, I have added just one new file.

The merge conflict is caused by the fact that I've merged one of your data PR so your local data submodule is out of sync.

Regarding the error, you might have committed the wrong file or the one in this PR is different from your local one hence the error on the CI.

Hephaestus12 commented 4 years ago

The merge conflict is caused by the fact that I've merged one of your data PR so your local data submodule is out of sync.

Right, that makes sense. I'll pull, rebase and push again.

Regarding the error, you might have committed the wrong file or the one in this PR is different from your local one hence the error on the CI.

Hmm fine, I'll check this out.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue is now being closed due to a lack of activity. Feel free to reopen it.