search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Solves issue #5070 #5130

Closed yuvraj2701 closed 3 years ago

yuvraj2701 commented 4 years ago

Moved fequals and fequals_abs to Fequal.h. I feel "Math::abs", "Math::is_nan" functions also need to be moved so that Fequal.h is completely independent of Math.h.

gf712 commented 4 years ago

You can see the error on the CI https://dev.azure.com/shogunml/shogun/_build/results?buildId=4013&view=logs&jobId=be3b03d7-4089-5ab3-9462-9af4d8b1dcdf&j=be3b03d7-4089-5ab3-9462-9af4d8b1dcdf&t=443ade06-68af-54ec-5bea-0e179d048f6f

It seems like you forgot to refactor the math unittest

yuvraj2701 commented 4 years ago

@gf712 sorry for the previous mistake. I made the required changes but still few tests are failing to which I am not able to find answers online. Could you please help?

yuvraj2701 commented 4 years ago

There is some issue related to Eigen3 https://dev.azure.com/shogunml/shogun/_build/results?buildId=4014&view=logs&j=f9754876-58be-5644-7278-7cc807306c84&t=174218aa-5153-53fa-666b-4bb48f7a77b4&l=78

LiuYuHui commented 4 years ago

There is some issue related to Eigen3 https://dev.azure.com/shogunml/shogun/_build/results?buildId=4014&view=logs&j=f9754876-58be-5644-7278-7cc807306c84&t=174218aa-5153-53fa-666b-4bb48f7a77b4&l=78

@yuvraj2701 I think this error is unrelated to your pr, the only thing you need to change is notebooks.

yuvraj2701 commented 4 years ago

@LiuYuHui can you please tell what changes have to be made? I don't think changing eigen3 version in CmakeLists.txt as per my system version and then making a PR would be a valid solution. I am not able to update eigen3 in my system as well.

LiuYuHui commented 4 years ago

@yuvraj2701 don't worry about MacOS ACCELERATE and MacOS MKL, those two ci was broken for a while, you just need to fix jupyter notebooks.

yuvraj2701 commented 4 years ago

ImportError: cannot import name 'Statistics' from 'shogun' (/build/src/interfaces/python/shogun.py)

@LiuYuHui this is one of the errors in jupyter notebook. I have not built the python interface on my system. Is it something related to that? What can I do to solve this?

gf712 commented 3 years ago

any updates here?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue is now being closed due to a lack of activity. Feel free to reopen it.