search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Allow Octave interface to compile with Octave v5++ installed #5140

Closed rchavp closed 3 years ago

rchavp commented 3 years ago

This PR is for users who want the Octave interface and have Octave version 5.x.x installed.

Synopsis: Compiled Shogun with the Octave interface (only that one) in Ubuntu 20.04 LTS. I followed the build steps from the Install page in the Home website, but it failed when it didn't find the header file "octave/config.h" My local Octave installation is version 5.2.0 and I found that the make templates didn't cater for any version higher than 4.x.x.

After adding the check for Octave version 5.x,x and pointing the compiler to the right header file (octave/octave-config.h) the compilation and installation went through with no issues. I also tested several of the examples within my Octave installation and they all run fine.

karlnapf commented 3 years ago

Great, thank you very much for that!

karlnapf commented 3 years ago

Our CI for the interface is down atm. It might take a little while until we fix it and then merge the PR (xmas etc). But much appreciated!

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue is now being closed due to a lack of activity. Feel free to reopen it.