shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Machine ref to itself #5145

Closed jonpsy closed 3 years ago

jonpsy commented 3 years ago

5139

Eren YEAGEEER!

@gf712 Some unit tests are failing still, submitting as early report.

jonpsy commented 3 years ago

It seems the failing tests haven't to do with my PR in particular, here's a report of failing test cases on develop branch and my branch

develop

     54 - generated_cpp-evaluation-cross_validation_support_vector_machine (SEGFAULT)
    159 - generated_cpp-regression-random_forest_regression (SEGFAULT)
    253 - unit-MeanSquaredTest (Failed)
    565 - integration_meta_cpp-binary-domainadaptationsvm (Failed)
    575 - integration_meta_cpp-binary-svmlight (Failed)
    576 - integration_meta_cpp-binary-svmlight_batch_linadd (Failed)
    690 - integration_meta_cpp-pipeline-pipeline (Failed)
    695 - integration_meta_cpp-preprocessor-pca (Failed)

machine branch

     159 - generated_cpp-regression-random_forest_regression (SEGFAULT)
        253 - unit-MeanSquaredTest (Failed)
        565 - integration_meta_cpp-binary-domainadaptationsvm (Failed)
        575 - integration_meta_cpp-binary-svmlight (Failed)
        576 - integration_meta_cpp-binary-svmlight_batch_linadd (Failed)
        690 - integration_meta_cpp-pipeline-pipeline (Failed)
        695 - integration_meta_cpp-preprocessor-pca (Failed)

This is true atleast in my local machine. This PR should be good to go, I'll let the members make the final call

LiuYuHui commented 3 years ago

I guess maybe there is some data race in cross_validation_support_vector_machine.

jonpsy commented 3 years ago

I guess maybe there is some data race in cross_validation_support_vector_machine.

5121

jonpsy commented 3 years ago

Re-open when devs are back.