search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Chain put #5149

Closed jonpsy closed 3 years ago

jonpsy commented 3 years ago

5047

I'm using shared_from_this() , which forces users to create objects using shared pointers.

In RandomMixin_unittest.cc, https://github.com/shogun-toolbox/shogun/blob/9b8d856971af5a295dd6ad70623ae45647a6334c/tests/unit/mathematics/RandomMixin_unittest.cc#L106

Is it necessary to use std::make_unique? Can't it be make_shared, that'll solve the test case error in this file.

jonpsy commented 3 years ago

Re-open when devs are back.