search

shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

[2] Circular #5153

Closed jonpsy closed 3 years ago

jonpsy commented 3 years ago

@gf712 I was pondering on why do we allow the users to specify the Distance Class? The formula is very clear with the distance metric to use. Besides, the distance metric being shift invariant is the very foundation on which I'm moving these classes inside SIV. I've taken the liberty to initialize the appropriate distance class by default inside the ctor. If you have differing opinion, lemme know :) #5151

gf712 commented 3 years ago

@gf712 I was pondering on why do we allow the users to specify the Distance Class? The formula is very clear with the distance metric to use. Besides, the distance metric being shift invariant is the very foundation on which I'm moving these classes inside SIV. I've taken the liberty to initialize the appropriate distance class by default inside the ctor. If you have differing opinion, lemme know :) #5151

Oh I guess this is why you changed it in the other PR? I think @karlnapf might be better suited to answer this question?

jonpsy commented 3 years ago

Re-open when the devs are back.