shogun-toolbox / shogun

Shōgun
http://shogun-toolbox.org
BSD 3-Clause "New" or "Revised" License
3.03k stars 1.04k forks source link

Fixes parameter names in each SGObject class #5174

Closed jaskiratsingh2000 closed 2 years ago

jaskiratsingh2000 commented 3 years ago

Before this commit the parameter names within the SGObject Class were using SG_ADD(&class_member, "name", "parameter description"). and with this the problem was that when changing the registered name (in this case "name") results in issues everytime there was refactoring of the parameters name. Hence to address this issue the class should register a static constexpr std::string_view kParam = "name" that should be used to register the class name which resolve this problem.

Hence this Pull Request resolve this fix by committing the files within following folders as mentioned below

📁 shogun
├── 📁 src
        └──📁 shogun
               ├── 📁 machine
               ├── 📁 clustering
               └── 📁 converter

Feel free to suggest any changes required. Thanks! :smiley:

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue is now being closed due to a lack of activity. Feel free to reopen it.