First shot to fix the reported median bug.

shogun-toolbox / shogun

Shōgun

http://shogun-toolbox.org

BSD 3-Clause "New" or "Revised" License

3.02k stars 1.04k forks source link

First shot to fix the reported median bug. #5190

Closed iglesias closed 6 months ago

iglesias commented 6 months ago

Hi!

It is still work in progress. Just in case, apologies for opening the pull request already.

iglesias commented 6 months ago

Reference: https://www.youtube.com/watch?v=cMRyQkrjEeI, by @danlark1. Timestamp 23:23

I have been trying to reproduce a mismatch. I plan to take a look at the _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY. Any help or taking over is welcomed!

lisitsyn commented 6 months ago

LGTM!

iglesias commented 6 months ago

It doesn't seem to be reproducible. At least to me 🤷‍♂️

https://godbolt.org/z/P4b1sbcsW

danlark1 commented 6 months ago

You should put the define before includes or in the command line, see

https://godbolt.org/z/Tx8rGrqoa

danlark1 commented 6 months ago

Or, for example, without any randomization

https://godbolt.org/z/vn5e7eW7M

iglesias commented 6 months ago

Oh! Thanks a lot for taking a look and getting back!