shoheiyokoyama / Koyomi

Simple customizable calendar component in Swift :calendar:
MIT License
749 stars 103 forks source link

What happen to 'toDate' parameter in didselect date method in Delegate? #23

Open stshelton opened 7 years ago

stshelton commented 7 years ago

Having trouble getting end date when using the selection mode "sequence". I had a previous version of this library on a different project and the "didSelect date" method in delegate had a "toDate" parameter that would provide the last date in sequence. Currently, that delegate method only has "didSelect date" which only returns the first date in the sequence even after the user clicked another date to complete sequence. Am I missing another function in the delegate, if not what would be the best method of retrieving the end date of the sequence of dates?

Also, I had an issue with Sat column disappearing when collection view is the same size of the screen. Once I added a trailing and leading constraint of 5 Sat column came back

v1ntage commented 7 years ago

I'm having these exact two issues too.

Overall these issues make it unusable in its current state, unfortunately, as this is a great lightweight solution.

zhangbool commented 7 years ago

Same issues with the two guys before, the end selected time is not right

danparnella commented 7 years ago

I would agree that the "toDate" parameter should be included again in the "didSelect" method, but as a workaround for now you can use the "shouldSelectDates" method which does include both "date" and "toDate".