search

shokai / websocket-client-simple

Simple WebSocket Client on Ruby
https://rubygems.org/gems/websocket-client-simple
MIT License
115 stars 68 forks source link

Abrandoned/non block #23

Open abrandoned opened 8 years ago

abrandoned commented 8 years ago

Not sure if this is wanted/needed/desired but updated sockets to use non_blocking calls and making the handshake synchronous (as it was a confusing part to troubleshoot when failure)

movitto commented 6 years ago

@abrandoned @shokai I know this is ~ two years old but any chance this could be merged into the upstream repo? I've been incorporating this library into a project I'm working on wipple and need a way to attempt to connect to a websocket server in a non-blocking fashion (so that if the connection fails to be established I can easily terminate the socket and try again).

I tried this PR out locally and it works great (though admitadely didn't go into the code in details). If this is just an issue of updating the PR to fix the CI failures, I can dedicate some time to investigating sending a followup PR addressing the problem. Just let me know.

And thanks for the great library and PR!!!