search

shokokayano / mobile-bookmark-bubble

Automatically exported from code.google.com/p/mobile-bookmark-bubble
Apache License 2.0
0 stars 0 forks source link

Bubble keeps popping up even after I add the bookmark?? #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Bubble keeps appearing even after I have added web app.
2.
3.

What is the expected output? What do you see instead?

Hi,

I am setting up a small mobile website for a client of mine and have 
implemented the bookmark_bubble into it.

I have got the bubble popping up perfectly with the icon and I have also edited 
the text that shows. However, even if I place a web app link on my home screen, 
then refresh the site, the bubble will re-appear and still keep popping up and 
prompting to add the web app to my phone.

I thought it was supposed to acknowledge that the user has added the web app or 
not so it can determine whether to keep prompting them.

What version of the product are you using? On what operating system?

Not sure..?

Please provide any additional information below.

Someone please help; any information is greatly appreciated!

Links to the bubble_bookmark javascript files being used are below:

http://insiteeyewear.com.au/sdo/m/js/bookmark.js

http://insiteeyewear.com.au/sdo/m/js/bubble.js

Original issue reported on code.google.com by samuel.n...@gmail.com on 29 Jun 2011 at 8:17

GoogleCodeExporter commented 9 years ago 
The problem is these lines in your bubble.js:

bubble.setHashParameter = function() { }

bubble.hasHashParameter = function() {
  return false;
}

Because of the way you've defined these functions, the bubble has no way of 
knowing if it has been shown, so it will continue to appear even after you 
create the bookmark. Note that if you dismiss the bubble a couple of times, it 
won't come back.

You could fix this by defining those two functions to actually set and check 
the value of the hash, as in the example posted on this site.

Original comment by ntho...@google.com on 4 Jul 2011 at 12:12

GoogleCodeExporter commented 9 years ago 
Thanks for the reply. I used the definitions from example.js and it is now 
working perfect.

Thanks again.

Original comment by samuel.n...@gmail.com on 4 Jul 2011 at 12:29